Baolong Mao created HDDS-9899:
---------------------------------
Summary: Update RIGHT_MARGIN to 120 for IntelliJ
Key: HDDS-9899
URL: https://issues.apache.org/jira/browse/HDDS-9899
Project: Apache Ozone
Issue Type: Improvement
Components: build
Reporter: Baolong Mao
Assignee: Tsz-wo Sze
In Ozone, we have many ugly code like the following in order to satisfy the 80
line width requirement.
{code}
//StorageContainerManager.java
FixedThreadPoolWithAffinityExecutor<IncrementalContainerReportFromDatanode,
ContainerReport> incrementalReportExecutors =
new FixedThreadPoolWithAffinityExecutor<>(
EventQueue.getExecutorName(
SCMEvents.INCREMENTAL_CONTAINER_REPORT,
incrementalContainerReportHandler),
incrementalContainerReportHandler, queues, eventQueue,
IncrementalContainerReportFromDatanode.class, executors,
reportExecutorMap);
{code}
Ugly code, is not only a cosmetic issue, leads to more bugs since it makes the
code harder to read.
We are currently following the Sun Code Conventions
-
https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#313
which says
- 4.1 Line Length
-* Avoid lines longer than 80 characters, since they're not handled well by
many terminals and tools.
This is probably true 20+ years ago. (It might be true for the old SUN
workstations?)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
