adoroszlai commented on code in PR #5780:
URL: https://github.com/apache/ozone/pull/5780#discussion_r1424961280
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientManager.java:
##########
@@ -297,6 +293,15 @@ private String getPipelineCacheKey(Pipeline pipeline,
e.getMessage());
}
}
+ // Append user short name to key to prevent a different user
+ // from using same instance of xceiverClient.
+ try {
+ key = isSecurityEnabled ?
+ key + UserGroupInformation.getCurrentUser().getShortUserName() : key;
+ } catch (IOException e) {
+ LOG.error("Failed to get current user to create pipeline cache key:" +
+ e.getMessage());
+ }
Review Comment:
We can simplify this (and avoid the `try-catch` if security is not enabled).
```suggestion
if (isSecurityEnabled) {
try {
key += UserGroupInformation.getCurrentUser().getShortUserName();
} catch (IOException e) {
LOG.error("Failed to get current user to create pipeline cache key:
" +
e.getMessage());
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
