[
https://issues.apache.org/jira/browse/HDDS-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-9650:
-----------------------------------
Description:
HDDS-5333 removed {{getRequestType}} method from OM request classes. There is
some leftover usage of this method via reflection. Such code is dead (tests
are disabled, production code is unused.)
https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMLayoutVersionManager.java#L130-L157
https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java#L108-L141
https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java#L104-L106
Please don't forget to also remove any imports that become unused.
was:
HDDS-5333 removed {{getRequestType}} method from OM request classes. There is
some leftover usage of this method via reflection. Such code is dead (tests
are disabled, production code is unused.)
Please wait for HDDS-9496 to be merged before starting work on this, as that
removes one of these test cases.
https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMLayoutVersionManager.java#L130-L157
https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java#L108-L141
https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java#L104-L106
> Remove dead code using getRequestType via reflections
> -----------------------------------------------------
>
> Key: HDDS-9650
> URL: https://issues.apache.org/jira/browse/HDDS-9650
> Project: Apache Ozone
> Issue Type: Task
> Components: Ozone Manager
> Reporter: Attila Doroszlai
> Priority: Major
>
> HDDS-5333 removed {{getRequestType}} method from OM request classes. There
> is some leftover usage of this method via reflection. Such code is dead
> (tests are disabled, production code is unused.)
> https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMLayoutVersionManager.java#L130-L157
> https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java#L108-L141
> https://github.com/apache/ozone/blob/4b9a1dc5908bababe85d750525b1bf3d01d7af55/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java#L104-L106
> Please don't forget to also remove any imports that become unused.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
