DaveTeng0 commented on code in PR #5742:
URL: https://github.com/apache/ozone/pull/5742#discussion_r1427115155
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java:
##########
@@ -340,7 +340,10 @@ public ContainerInfo getMatchingContainer(final long size,
final String owner,
}
} catch (Exception e) {
LOG.warn("Container allocation failed on pipeline={}", pipeline, e);
- return null;
+ return new ContainerInfo.Builder()
+ .setContainerID(-1)
Review Comment:
hm, interesting. It seems 0 is a valid value and every container ID starts
from 1. So I guess we could use 0 to indicate method's caller the pipelineID of
the container allocation failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
