adoroszlai opened a new pull request, #5802: URL: https://github.com/apache/ozone/pull/5802
## What changes were proposed in this pull request? `ContainerTestVersionInfo` is used in several classes to parameterize test methods. The goal of this change is to reduce code duplication by defining a [composite annotation](https://junit.org/junit5/docs/current/user-guide/#writing-tests-meta-annotation). (Will create follow-up tasks for other similar common parameter types.) https://issues.apache.org/jira/browse/HDDS-9932 ## How was this patch tested? Tests changed by this PR were executed normally (no change in test count, etc.). Before: ``` Tests run: 136, Failures: 0, Errors: 0, Skipped: 8, Time elapsed: 13.51 s -- in org.apache.hadoop.ozone.container.common.impl.TestContainerPersistence Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.915 s -- in org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteBlocksCommandHandler Tests run: 56, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 20.63 s -- in org.apache.hadoop.ozone.container.common.TestBlockDeletingService Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.429 s -- in org.apache.hadoop.ozone.container.common.TestKeyValueContainerData Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.279 s -- in org.apache.hadoop.ozone.container.common.TestStaleRecoveringContainerScrubbingService Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.321 s -- in org.apache.hadoop.ozone.container.keyvalue.impl.TestBlockManagerImpl Tests run: 177, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 46.47 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainer Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.134 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainerCheck Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.250 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainerMarkUnhealthy Tests run: 72, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.854 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainerMetadataInspector Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.85 s -- in org.apache.hadoop.ozone.container.ozoneimpl.TestContainerReader Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.389 s -- in org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainer ``` After: ``` Tests run: 136, Failures: 0, Errors: 0, Skipped: 8, Time elapsed: 14.63 s -- in org.apache.hadoop.ozone.container.common.impl.TestContainerPersistence Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.825 s -- in org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteBlocksCommandHandler Tests run: 56, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 21.34 s -- in org.apache.hadoop.ozone.container.common.TestBlockDeletingService Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.335 s -- in org.apache.hadoop.ozone.container.common.TestKeyValueContainerData Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.658 s -- in org.apache.hadoop.ozone.container.common.TestStaleRecoveringContainerScrubbingService Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.310 s -- in org.apache.hadoop.ozone.container.keyvalue.impl.TestBlockManagerImpl Tests run: 177, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 48.81 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainer Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.884 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainerCheck Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.064 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainerMarkUnhealthy Tests run: 72, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.305 s -- in org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainerMetadataInspector Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.66 s -- in org.apache.hadoop.ozone.container.ozoneimpl.TestContainerReader Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.223 s -- in org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainer ``` CI: https://github.com/adoroszlai/ozone/actions/runs/7223199990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
