TaiJuWu commented on PR #5753: URL: https://github.com/apache/ozone/pull/5753#issuecomment-1858178084
> Thank you @TaiJuWu for the patch. This clean up would be very helpful. I have left a few comments. > > I did some very rough work on this cleanup in [ivandika3@4803bb2](https://github.com/ivandika3/ozone/commit/4803bb27faa4b7790763d9952520fa62fd057d39). It's still in a very rough form and failed tests, but I hope it would help. > > As @jojochuang said, there are still some duplications left, like in `OMMultipartUploadUtils#getMultipartOpenKeyFSO`, `S3MultipartUploadCompleteRequestWithFSO`, etc. My rough draft covered some of these classes, but I might miss some. We can revisit it in future patches. > Thank you @TaiJuWu for the patch. This clean up would be very helpful. I have left a few comments. > > I did some very rough work on this cleanup in [ivandika3@4803bb2](https://github.com/ivandika3/ozone/commit/4803bb27faa4b7790763d9952520fa62fd057d39). It's still in a very rough form and failed tests, but I hope it would help. > > As @jojochuang said, there are still some duplications left, like in `OMMultipartUploadUtils#getMultipartOpenKeyFSO`, `S3MultipartUploadCompleteRequestWithFSO`, etc. My rough draft covered some of these classes, but I might miss some. We can revisit it in future patches. Im not sure our CI fail is same or not. But I fail CI test on org.apache.hadoop.ozone.debug.TestLeaseRecoverer.testCLI(TestLeaseRecoverer.java:140. I still try to find this reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
