adoroszlai opened a new pull request, #5804: URL: https://github.com/apache/ozone/pull/5804
## What changes were proposed in this pull request? There are some leftover JUnit4 imports in modules already migrated. It looks like ban of JUnit4 import did not catch these, due to two problems: 1. `org.junit.*` does not match sub-packages (`org.junit.rules.*` etc.) 2. basic analysis of `TestKeyValueContainer` does not find `org.junit.Assume`, have to enable full parsing https://issues.apache.org/jira/browse/HDDS-9935 ## How was this patch tested? Verified that the build catches the following banned imports: ``` [ERROR] in file: org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainer.java [ERROR] org.junit.Assume (Line: 62, Matched by: org.junit.**) [ERROR] in file: org/apache/hadoop/ozone/container/replication/TestContainerImporter.java [ERROR] org.junit.rules.TemporaryFolder (Line: 47, Matched by: org.junit.**) [ERROR] in file: org/apache/hadoop/hdds/scm/pipeline/TestWritableECContainerProvider.java [ERROR] org.junit.runners.Parameterized (Line: 46, Matched by: org.junit.**) [ERROR] in file: org/apache/hadoop/hdds/scm/server/TestSCMBlockProtocolServer.java [ERROR] org.junit.platform.commons.util.Preconditions (Line: 56, Matched by: org.junit.**) [ERROR] in file: org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java [ERROR] org.junit.experimental.categories.Category (Line: 37, Matched by: org.junit.**) [ERROR] in file: org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java [ERROR] org.junit.experimental.categories.Category (Line: 53, Matched by: org.junit.**) [ERROR] in file: org/apache/hadoop/ozone/security/acl/TestParentAcl.java [ERROR] org.junit.experimental.categories.Category (Line: 55, Matched by: org.junit.**) [ERROR] in file: org/apache/hadoop/ozone/recon/ReconTestInjector.java [ERROR] org.junit.rules.TemporaryFolder (Line: 48, Matched by: org.junit.**) ``` Ran the tests locally. CI: https://github.com/adoroszlai/ozone/actions/runs/7225910524/job/19690609347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
