xichen01 commented on code in PR #5789:
URL: https://github.com/apache/ozone/pull/5789#discussion_r1428812568
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1854,7 +1855,7 @@ public OzoneDataStreamOutput createMultipartStreamKey(
.setMultipartUploadID(uploadID)
.setIsMultipartKey(true)
.enableUnsafeByteBufferConversion(unsafeByteBufferConversion)
- .setConfig(conf.getObject(OzoneClientConfig.class))
+ .setConfig(clientConfig)
Review Comment:
I understand, but here we are using `Configuration` to pass parameters,
which shouldn't be the role of `Configuration`. If a parameter needs to be
computed at runtime, it should not be directly obtained from Configuration.
Therefore, I added a `StreamBufferArgs` to modify and pass the StreamBuffe
related parameters .
IMO, Configuration should ideally not provide a direct `set` method.
Modifications to Configuration should only occur in "test code" and during
"reconfiguration". Otherwise, Configuration should be read-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
