adoroszlai opened a new pull request, #5808:
URL: https://github.com/apache/ozone/pull/5808
## What changes were proposed in this pull request?
`OzonePBHelper` exists in two implementations, one for
`HddsProtos.TokenProto`, one for `SecurityProtos.TokenProto`. Both
implementations use a simple map to cache some `ByteString` instances. While
the specific proto conversion code needs to be separate, generic utils and the
cache itself could be shared.
Similar token/proto conversion methods are also defined in `OMPBHelper` for
delegation token. These can be refactored to further reduce duplication.
This PR:
* removes duplicate methods and map from `OzonePBHelper` in `ozone-common`
* moves `OzonePBHelper` from `hdds-framework` to `hdds-common` to be able
to share with the one in `ozone-common`
* merges remaining methods of `OzonePBHelper` in `ozone-common` into
`OMPBHelper`
* adds javadoc to clarify the difference between the similar methods in the
two helper classes
https://issues.apache.org/jira/browse/HDDS-9882
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7233729708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
