[ 
https://issues.apache.org/jira/browse/HDDS-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798067#comment-17798067
 ] 

Siddhant Sangwan commented on HDDS-9947:
----------------------------------------

As far as I understand the reason for making this an {{INFO}} level log is that 
a {{NotLeaderException}} should only be thrown in follower SCMs. In that 
situation, this isn't really an error and only an information. However, if this 
is somehow thrown in the leader SCM, then it actually is an error.

> org.apache.hadoop.hdds.scm.exceptions.SCMException: 
> org.apache.ratis.protocol.exceptions.NotLeaderException: change from ERROR to 
> INFO
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-9947
>                 URL: https://issues.apache.org/jira/browse/HDDS-9947
>             Project: Apache Ozone
>          Issue Type: Bug
>            Reporter: Tejaskriya Madhan
>            Assignee: Tejaskriya Madhan
>            Priority: Major
>              Labels: pull-request-available
>
> in ozone-scm.log, NotLeaderException should be informational, we may want to 
> change it from ERROR to INFO:
> {code:java}
> 2023-12-04 17:46:25,297 ERROR 
> [FixedThreadPoolWithAffinityExecutor-9-0]-org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler:
>  Exception while processing ICR for container 4113
> org.apache.hadoop.hdds.scm.exceptions.SCMException: 
> org.apache.ratis.protocol.exceptions.NotLeaderException: Server 
> 465561e9-39d8-403a-bb48-f86b13824529@group-6F9D1602902C is not the leader 
> e5797e4a-85f7-4a6d-8ba6-8f13d24a2f30|rpc:ve0310.halxg.cloudera.com:9894|admin:|client:|dataStream:|priority:0|startupRole:FOLLOWER
>         at 
> org.apache.hadoop.hdds.scm.ha.SCMHAInvocationHandler.translateException(SCMHAInvocationHandler.java:170)
>         at 
> org.apache.hadoop.hdds.scm.ha.SCMHAInvocationHandler.invokeRatis(SCMHAInvocationHandler.java:108)
>         at 
> org.apache.hadoop.hdds.scm.ha.SCMHAInvocationHandler.invoke(SCMHAInvocationHandler.java:76)
>         at com.sun.proxy.$Proxy21.updateContainerState(Unknown Source)
>         at 
> org.apache.hadoop.hdds.scm.container.ContainerManagerImpl.updateContainerState(ContainerManagerImpl.java:276)
>         at 
> org.apache.hadoop.hdds.scm.container.AbstractContainerReportHandler.updateContainerState(AbstractContainerReportHandler.java:315)
>         at 
> org.apache.hadoop.hdds.scm.container.AbstractContainerReportHandler.processContainerReplica(AbstractContainerReportHandler.java:120)
>         at 
> org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler.onMessage(IncrementalContainerReportHandler.java:100)
>         at 
> org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler.onMessage(IncrementalContainerReportHandler.java:43)
>         at 
> org.apache.hadoop.hdds.server.events.FixedThreadPoolWithAffinityExecutor$ContainerReportProcessTask.run(FixedThreadPoolWithAffinityExecutor.java:276)
>         at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>         at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>         at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>         at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.ratis.protocol.exceptions.NotLeaderException: Server 
> 465561e9-39d8-403a-bb48-f86b13824529@group-6F9D1602902C is not the leader 
> e5797e4a-85f7-4a6d-8ba6-8f13d24a2f30|rpc:ve0310.halxg.cloudera.com:9894|admin:|client:|dataStream:|priority:0|startupRole:FOLLOWER
>         at 
> org.apache.ratis.server.impl.RaftServerImpl.generateNotLeaderException(RaftServerImpl.java:744)
>         at 
> org.apache.ratis.server.impl.RaftServerImpl.checkLeaderState(RaftServerImpl.java:709)
>         at 
> org.apache.ratis.server.impl.RaftServerImpl.submitClientRequestAsync(RaftServerImpl.java:850)
>         at 
> org.apache.ratis.server.impl.RaftServerImpl.lambda$null$12(RaftServerImpl.java:831)
>         at org.apache.ratis.util.JavaUtils.callAsUnchecked(JavaUtils.java:117)
>         at 
> org.apache.ratis.server.impl.RaftServerImpl.lambda$executeSubmitClientRequestAsync$13(RaftServerImpl.java:831)
>         at 
> java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
>         ... 3 more{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to