siddhantsangwan commented on code in PR #5688:
URL: https://github.com/apache/ozone/pull/5688#discussion_r1430041409
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestNodeDecommissionManager.java:
##########
@@ -186,6 +186,41 @@ public void testNodesCanBeDecommissionedAndRecommissioned()
nodeManager.getNodeStatus(duplicatePorts).getOperationalState());
}
+ @Test
+ public void testStartTimeMetricWhenNodesDecommissioned() throws Exception {
+ List<DatanodeDetails> dns = generateDatanodes();
+
+ // Decommission 2 valid nodes
+ long beforeTime = System.currentTimeMillis();
+ decom.decommissionNodes(Arrays.asList(dns.get(1).getIpAddress(),
+ dns.get(2).getIpAddress()));
+ long afterTime = System.currentTimeMillis();
+
+ assertEquals(HddsProtos.NodeOperationalState.DECOMMISSIONING,
+ nodeManager.getNodeStatus(dns.get(1)).getOperationalState());
+
+ long decomTimeDn1 = decom.getNodeDecommissionMetrics()
+ .getStartTimeByHost(dns.get(1).getHostName());
+ assertTrue(decomTimeDn1 >= beforeTime);
+ assertTrue(decomTimeDn1 <= afterTime);
+
+ assertEquals(HddsProtos.NodeOperationalState.DECOMMISSIONING,
+ nodeManager.getNodeStatus(dns.get(2)).getOperationalState());
+
+ long decomTimeDn2 = decom.getNodeDecommissionMetrics()
+ .getStartTimeByHost(dns.get(2).getHostName());
+ assertTrue(decomTimeDn2 >= beforeTime);
+ assertTrue(decomTimeDn2 <= afterTime);
+
+ assertNotEquals(decomTimeDn1, decomTimeDn2);
Review Comment:
Unfortunately `System.currentTimeMillis()` is non monotonic, so the two
times can actually be equal sometimes. It's best to remove this check to avoid
flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
