adoroszlai commented on code in PR #5817:
URL: https://github.com/apache/ozone/pull/5817#discussion_r1430462122
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/balancer/TestContainerBalancer.java:
##########
@@ -127,31 +128,26 @@ public void testStartBalancerStop() throws Exception {
startBalancer(balancerConfiguration);
try {
containerBalancer.startBalancer(balancerConfiguration);
- Assertions.assertTrue(false,
- "Exception should be thrown when startBalancer again");
+ Assertions.fail("Exception should be thrown when startBalancer again");
Review Comment:
Thanks for the suggestion. I also planned to create another task for
`assertThrows`, now filed HDDS-9956.
Creating these as top-level issues so that we can create sub-tasks for
specific modules if needed (to avoid too large patches).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
