szetszwo commented on code in PR #5805:
URL: https://github.com/apache/ozone/pull/5805#discussion_r1428975562
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/GrpcXceiverService.java:
##########
@@ -121,6 +133,9 @@ public void onNext(ContainerCommandRequestProto request) {
if (popStream != null) {
IOUtils.close(LOG, popStream);
}
+ if (context != null) {
Review Comment:
@duongkame , Good catch! We should if we make DispatcherContext closable
for releasing buffers.
On a second thought, HDDS-7117 already has changed using `MappedByteBuffer`
instead of allocating buffers when the size is larger than
`ozone.chunk.read.mapped.buffer.threshold` (default 32KB). So, it seems that
we don't have do anything for read. Could you test HDDS-9536 with the current
code?
(Revised: fixed typo: "small" -> "larger")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
