aswinshakil commented on code in PR #5815:
URL: https://github.com/apache/ozone/pull/5815#discussion_r1430683705
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/OzoneTestUtils.java:
##########
@@ -92,7 +92,7 @@ public static void closeContainers(
.updateContainerState(ContainerID.valueOf(blockID.getContainerID()),
HddsProtos.LifeCycleEvent.CLOSE);
}
- Assert.assertFalse(scm.getContainerManager()
+ Assertions.assertFalse(scm.getContainerManager()
Review Comment:
Nit: Can we import the static methods itself like in other test changes?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestSCMInstallSnapshot.java:
##########
@@ -144,26 +148,24 @@ public void testInstallCheckPoint() throws Exception {
scm.getPipelineManager().getPipelines().get(0).getId();
scm.getScmMetadataStore().getPipelineTable().delete(pipelineID);
scm.getContainerManager().deleteContainer(cid);
- Assert.assertNull(
+ assertNull(
scm.getScmMetadataStore().getPipelineTable().get(pipelineID));
- Assert.assertFalse(scm.getContainerManager().containerExist(cid));
+ assertFalse(scm.getContainerManager().containerExist(cid));
SCMStateMachine sm =
scm.getScmHAManager().getRatisServer().getSCMStateMachine();
sm.pause();
sm.setInstallingSnapshotData(checkpoint, null);
sm.reinitialize();
- Assert.assertNotNull(
- scm.getScmMetadataStore().getPipelineTable().get(pipelineID));
- Assert.assertNotNull(
- scm.getScmMetadataStore().getContainerTable().get(cid));
- Assert.assertTrue(scm.getPipelineManager().containsPipeline(pipelineID));
- Assert.assertTrue(scm.getContainerManager().containerExist(cid));
- Assert.assertEquals(100, scm.getScmMetadataStore().
+
assertNotNull(scm.getScmMetadataStore().getPipelineTable().get(pipelineID));
+ assertNotNull(scm.getScmMetadataStore().getContainerTable().get(cid));
+ assertTrue(scm.getPipelineManager().containsPipeline(pipelineID));
+ assertTrue(scm.getContainerManager().containerExist(cid));
+ assertEquals(100, scm.getScmMetadataStore().
getTransactionInfoTable().get(OzoneConsts.TRANSACTION_INFO_KEY)
.getTransactionIndex());
- Assert.assertEquals(100,
+ assertEquals(100,
Review Comment:
Nit: Now that the line length is increased to 120, We can use that here and
in other changes as well ;)
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconInsightsForDeletedDirectories.java:
##########
@@ -136,7 +132,7 @@ public void cleanup() {
fs.delete(fileStatus.getPath(), true);
}
} catch (IOException ex) {
- fail("Failed to cleanup files.");
+ Assertions.fail("Failed to cleanup files.");
Review Comment:
Same as above. We can import the static functions.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/TestBlockDeletion.java:
##########
@@ -631,7 +630,7 @@ public void testContainerDeleteWithInvalidKeyCount()
= scm.getContainerManager().getContainerReplicas(containerId);
// Ensure for all replica isEmpty are false in SCM
- Assert.assertTrue(scm.getContainerManager().getContainerReplicas(
+ Assertions.assertTrue(scm.getContainerManager().getContainerReplicas(
Review Comment:
Same as the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
