sodonnel commented on code in PR #5746: URL: https://github.com/apache/ozone/pull/5746#discussion_r1431765038
########## hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestReplicationManagerScenarios.java: ########## @@ -0,0 +1,783 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.scm.container.replication; + +import com.fasterxml.jackson.databind.MappingIterator; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.ObjectReader; +import org.apache.commons.lang3.tuple.Pair; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.client.RatisReplicationConfig; +import org.apache.hadoop.hdds.client.ReplicationConfig; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.MockDatanodeDetails; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerReplicaProto; +import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.SCMCommandProto; +import org.apache.hadoop.hdds.scm.PlacementPolicy; +import org.apache.hadoop.hdds.scm.container.ContainerID; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerManager; +import org.apache.hadoop.hdds.scm.container.ContainerReplica; +import org.apache.hadoop.hdds.scm.container.ReplicationManagerReport; +import org.apache.hadoop.hdds.scm.ha.SCMContext; +import org.apache.hadoop.hdds.scm.node.NodeManager; +import org.apache.hadoop.hdds.scm.node.NodeStatus; +import org.apache.hadoop.hdds.scm.node.states.NodeNotFoundException; +import org.apache.hadoop.hdds.server.events.EventPublisher; +import org.apache.hadoop.ozone.protocol.commands.ReplicateContainerCommand; +import org.apache.hadoop.ozone.protocol.commands.SCMCommand; +import org.apache.ozone.test.TestClock; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; +import org.mockito.Mockito; + +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.net.URI; +import java.net.URISyntaxException; +import java.time.Instant; +import java.time.ZoneId; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.stream.Stream; + +import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_SCM_WAIT_TIME_AFTER_SAFE_MODE_EXIT; +import static org.mockito.ArgumentMatchers.any; + +/** + * This class tests the replication manager using a set of scenarios defined in + * JSON files. The scenarios define a container and a set of replicas, and the + * expected results from the replication manager. The scenarios are defined in + * JSON files in the test resources directory. The test files are loaded in + * {@link #init()} and the tests are run in {@link #testAllScenarios(Scenario)}. + * + * There are several inner class defined within this class, and they are used to + * deserialize the JSON files into Java objects. In general any field which is a + * setter on the inner class can be set in the JSON file. + * + * TODO - The framework does not allow for testing mis-replicated containers. + */ + +public class TestReplicationManagerScenarios { + private static final Map<String, UUID> ORIGINS = new HashMap<>(); + private static final Map<String, DatanodeDetails> DATANODE_ALIASES + = new HashMap<>(); + private static final Map<DatanodeDetails, NodeStatus> NODE_STATUS_MAP + = new HashMap<>(); + private static final String TEST_RESOURCE_PATH = "/replicationManagerTests"; + private static final List<Scenario> TEST_SCENARIOS = new ArrayList<>(); + + private Map<ContainerID, Set<ContainerReplica>> containerReplicaMap; + private Set<ContainerInfo> containerInfoSet; + private ContainerReplicaPendingOps containerReplicaPendingOps; + private Set<Pair<UUID, SCMCommand<?>>> commandsSent; + + private OzoneConfiguration configuration; + private ReplicationManager replicationManager; + private LegacyReplicationManager legacyReplicationManager; + private ContainerManager containerManager; + private PlacementPolicy ratisPlacementPolicy; + private PlacementPolicy ecPlacementPolicy; + private EventPublisher eventPublisher; + private SCMContext scmContext; + private NodeManager nodeManager; + private TestClock clock; + private ReplicationManagerReport repReport; + private ReplicationQueue repQueue; Review Comment: Yea, I guess they can be locals as they are just used in the test method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
