adoroszlai commented on code in PR #5839:
URL: https://github.com/apache/ozone/pull/5839#discussion_r1432453848
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/ContainerLayoutTestInfo.java:
##########
@@ -121,4 +127,15 @@ public static Iterable<Object[]>
containerLayoutParameters() {
.map(each -> new Object[] {each})
.collect(toList());
}
+
+ /**
+ * Composite annotation for tests parameterized with {@link
ContainerLayoutTestInfo}.
+ */
+ @Target(ElementType.METHOD)
+ @Retention(RetentionPolicy.RUNTIME)
+ @ParameterizedTest
+
@MethodSource("org.apache.hadoop.ozone.container.keyvalue.ContainerLayoutTestInfo#containerLayoutParameters")
Review Comment:
We can completely remove the method `containerLayoutParameters`, which was
necessary only for JUnit4. But JUnit5 works with strongly typed parameters, so
we can use `getAllVersions` directly.
```suggestion
@MethodSource("org.apache.hadoop.ozone.container.common.impl.ContainerLayoutVersion#getAllVersions")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
