[
https://issues.apache.org/jira/browse/HDDS-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798978#comment-17798978
]
Attila Doroszlai commented on HDDS-9170:
----------------------------------------
[~hemantk], I would like to suggest:
# using {{AssertJ}} instead of {{Hamcrest}} (found a doc
[comparing|https://truth.dev/comparison] Google Truth, AssertJ and Hamcrest;
the first two seem to have nice advantages over the latter for this use case,
and Ozone already has dependency on AssertJ, but not on Truth)
# using {{assertThat}} more generally, for most {{assertTrue}},
{{assertFalse}}, instead of just exception messages (I've recently filed
HDDS-9951 for that, sorry I didn't see this one)
# dividing the task into sub-task per module to
#* make the change more manageable
#* possibly do it in parallel, and
#* give new contributors a chance to help with it
> Deprecate GenericTestUtils#assertExceptionContains and use Hamcrest#assertThat
> ------------------------------------------------------------------------------
>
> Key: HDDS-9170
> URL: https://issues.apache.org/jira/browse/HDDS-9170
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Hemant Kumar
> Assignee: Hemant Kumar
> Priority: Major
>
> This task is deprecate *GenericTestUtils#assertExceptionContains* and use
> *Hamcrest#assertThat* to validate exception message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
