sumitagrawl opened a new pull request, #5848:
URL: https://github.com/apache/ozone/pull/5848

   ## What changes were proposed in this pull request?
   
   lastAppliedTransaction update can happen from two place double buffer 
(applyTransaction) and ratis (notifyTermIndexUpdated). Its updated considering 
sequence of index provided, but there observed miss in index from 
applyTransaction, i.e. when some failure has happened and not added to double 
buffer. 
   
   In this case, all index keeps adding to ratisTransactionMap and increase in 
memory as this is never released as gap in sequence of index has happened. So 
lastAppliedTransaction will not get updated.
   
   This impacts further operation like Prepare Request, snapshot. So Snapshot 
taken has considered lastAppliedIndex (old value) and updated transaction info 
table, caused HDDS-9342.
   
   As fix, avoid handling transaction in sequence from double buffer, as these 
are transaction applied in sequence. And index from ratis 
(notifyTermIndexUpdated) are just get updated in sequence after that. The 
sequence need not be verified in sequence strictly.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-9960
   
   ## How was this patch tested?
   
   - existing testcase (as this change is just avoid accumulation on index in 
certain failure scenario)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to