wzhallright commented on code in PR #5850:
URL: https://github.com/apache/ozone/pull/5850#discussion_r1434642797
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestAddRemoveOzoneManager.java:
##########
@@ -131,10 +132,10 @@ private void assertNewOMExistsInPeerList(String nodeId)
throws Exception {
+ " not present in Peer list of OM " + om.getOMNodeId());
assertTrue(om.getOmRatisServer().doesPeerExist(nodeId), "New OM node " +
nodeId
+ " not present in Peer list of OM " + om.getOMNodeId() + "
RatisServer");
- assertTrue(
- om.getOmRatisServer().getCurrentPeersFromRaftConf().contains(nodeId),
- "New OM node " + nodeId + " not present in " + "OM "
- + om.getOMNodeId() + "RatisServer's RaftConf");
+ assertThat(
+ om.getOmRatisServer().getCurrentPeersFromRaftConf())
+ .withFailMessage("New OM node " + nodeId + " not present in " +
"OM "
+ + om.getOMNodeId() + "RatisServer's RaftConf").contains(nodeId);
Review Comment:
Okay, learned it and fixed
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestAddRemoveOzoneManager.java:
##########
@@ -197,9 +199,8 @@ public void testBootstrap() throws Exception {
GenericTestUtils.waitFor(() -> cluster.getOMLeader() != null, 500, 30000);
OzoneManager omLeader = cluster.getOMLeader();
- assertTrue(newOMNodeIds.contains(omLeader.getOMNodeId()),
- "New Bootstrapped OM not elected Leader even though" +
- " other OMs are down");
+ assertThat(newOMNodeIds).withFailMessage("New Bootstrapped OM not elected
Leader even though" +
+ " other OMs are down").contains(omLeader.getOMNodeId());
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
