adoroszlai commented on PR #5854:
URL: https://github.com/apache/ozone/pull/5854#issuecomment-1867355243
Thanks @david1859168 for working on this.
There are some conflicts with current `master` branch, which need to be
resolved manually. Please merge from `master`, resolve the conflicts, then
push to your fork again.
Also, checkstyle reports the following problems:
```
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokens.java
53: Unused import - org.apache.ozone.test.JUnit5AwareTimeout.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerOperations.java
32: Using the '.*' form of import should be avoided -
org.junit.jupiter.api.*.
53: 'class def modifier' has incorrect indentation level 1, expected level
should be 0.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneOMHACluster.java
24: Using the '.*' form of import should be avoided -
org.junit.jupiter.api.*.
27: Unused import - java.io.IOException.
48: Variable 'exception' must be private and have accessor methods.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestBlockTokensCLI.java
36: Using the '.*' form of import should be avoided -
org.junit.jupiter.api.*.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestSecretKeysApi.java
42: Unused import - org.apache.ozone.test.JUnit5AwareTimeout.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestContainerReportWithKeys.java
40: Using the '.*' form of import should be avoided -
org.junit.jupiter.api.*.
42: Unused import - org.apache.ozone.test.JUnit5AwareTimeout.
69: Variable 'exception' must be private and have accessor methods.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerStateMachineIdempotency.java
40: Using the '.*' form of import should be avoided -
org.junit.jupiter.api.*.
```
https://github.com/david1859168/ozone/actions/runs/7296598719/job/19884620249
You can run checkstyle locally by:
```
hadoop-ozone/dev-support/checks/checkstyle.sh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]