adoroszlai commented on code in PR #5849:
URL: https://github.com/apache/ozone/pull/5849#discussion_r1434988765
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/security/symmetric/TestLocalKeyStore.java:
##########
@@ -70,13 +71,13 @@ void setup() throws IOException {
static Stream<Arguments> saveAndLoadTestCases() throws Exception {
return Stream.of(
// empty
- Arguments.of(ImmutableList.of()),
+ of(ImmutableList.of()),
// single secret keys.
- Arguments.of(newArrayList(
+ of(newArrayList(
generateKey("HmacSHA256")
)),
// multiple secret keys.
- Arguments.of(newArrayList(
+ of(newArrayList(
Review Comment:
Let's keep `Arguments.of`, since `of` is very generic. For example we also
have `Stream.of` and `ImmutableList.of` in this short method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
