Attila Doroszlai created HDDS-10007:
---------------------------------------
Summary: Rename ManagedSstFileReader in rocksdb-checkpoint-differ
Key: HDDS-10007
URL: https://issues.apache.org/jira/browse/HDDS-10007
Project: Apache Ozone
Issue Type: Bug
Components: Snapshot
Affects Versions: 1.4.0
Reporter: Attila Doroszlai
{code:title=https://github.com/apache/ozone/blob/f9167a359e7ff6f54eafc8a7b1c3fd165050160f/hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedSstFileReader.java#L23-L26}
/**
* Managed SstFileReader.
*/
public class ManagedSstFileReader extends ManagedObject<SstFileReader> {
{code}
{code:title=https://github.com/apache/ozone/blob/f9167a359e7ff6f54eafc8a7b1c3fd165050160f/hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/ManagedSstFileReader.java#L48-L52}
/**
* ManagedSstFileReader provides an abstraction layer using which we can
* iterate over multiple underlying SST files transparently.
*/
public class ManagedSstFileReader {
{code}
{{ManagedSstFileReader}} in {{rocksdb-checkpoint-differ}} should be renamed to
avoid confusion with the "real" {{ManagedSstFileReader}} from
{{hdds-managed-rocksdb}}.
I think {{SstFileSetReader}} would be a better name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
