Attila Doroszlai created HDDS-10008:
---------------------------------------
Summary: Restrict allowed rocksdb imports in
rocksdb-checkpoint-differ
Key: HDDS-10008
URL: https://issues.apache.org/jira/browse/HDDS-10008
Project: Apache Ozone
Issue Type: Bug
Components: Snapshot
Affects Versions: 1.4.0
Reporter: Attila Doroszlai
{{rocksdb-checkpoint-differ}} overrides import restrictions on rocksdb classes
from root POM.
{code:title=https://github.com/apache/ozone/blob/f9167a359e7ff6f54eafc8a7b1c3fd165050160f/hadoop-hdds/rocksdb-checkpoint-differ/pom.xml#L125-L150}
<RestrictImports>
<includeTestCode>false</includeTestCode>
<reason>Use managed RocksObjects under
org.apache.hadoop.hdds.utils.db.managed instead.</reason>
<!-- By default, ban all the classes in org.rocksdb -->
<bannedImport>org.rocksdb.**</bannedImport>
<allowedImports>
<allowedImport>org.rocksdb.AbstractEventListener</allowedImport>
<allowedImport>org.rocksdb.Checkpoint</allowedImport>
<allowedImport>org.rocksdb.ColumnFamilyDescriptor</allowedImport>
<allowedImport>org.rocksdb.ColumnFamilyHandle</allowedImport>
<allowedImport>org.rocksdb.ColumnFamilyOptions</allowedImport>
<allowedImport>org.rocksdb.CompactionJobInfo</allowedImport>
<allowedImport>org.rocksdb.CompressionType</allowedImport>
<allowedImport>org.rocksdb.DBOptions</allowedImport>
<allowedImport>org.rocksdb.FlushOptions</allowedImport>
<allowedImport>org.rocksdb.LiveFileMetaData</allowedImport>
<allowedImport>org.rocksdb.Options</allowedImport>
<allowedImport>org.rocksdb.RocksDB</allowedImport>
<allowedImport>org.rocksdb.RocksDBException</allowedImport>
<allowedImport>org.rocksdb.SstFileReader</allowedImport>
<allowedImport>org.rocksdb.TableProperties</allowedImport>
<allowedImport>org.rocksdb.ReadOptions</allowedImport>
<allowedImport>org.rocksdb.SstFileReaderIterator</allowedImport>
</allowedImports>
<exclusion>org.apache.hadoop.hdds.utils.db.managed.*</exclusion>
</RestrictImports>
{code}
* Some of these are unnecessary, this module could use {{Managed...}} classes
instead. Using non-managed versions prevents leak detection.
* Some are OK to use and could be moved to root POM.
* {{exclusion}} is useless since this module does not define classes in the
{{org.apache.hadoop.hdds.utils.db.managed}} package.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
