wzhallright commented on code in PR #5862:
URL: https://github.com/apache/ozone/pull/5862#discussion_r1436185214
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBTableStore.java:
##########
@@ -692,7 +694,7 @@ public void testDumpAndLoadBasic() throws Exception {
// check dump file exist
assertTrue(dumpFile.exists());
- assertTrue(dumpFile.length() != 0);
+ assertNotEquals(1, dumpFile.length());
Review Comment:
fixed
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/server/TestJsonUtils.java:
##########
@@ -46,7 +46,8 @@ public void printObjectAsJson() throws IOException {
}
private static void assertContains(String str, String part) {
- assertTrue(str.contains(part),
- "Expected JSON to contain '" + part + "', but didn't: " + str);
+ assertThat(str)
+ .withFailMessage("Expected JSON to contain '" + part + "', but didn't:
" + str)
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
