ChenSammi commented on PR #5860: URL: https://github.com/apache/ozone/pull/5860#issuecomment-1870007180
@szetszwo , thanks working on this, the idea is very straight forward. But from performance and GC point of view, the TransactionInfo.value() construction in applyTransaction is expensive compared with current solution. In TransactionInfo.value(), it will construct a transactionInfoString every time which is not needed in applyTransaction case. Instead of pass in TransactionInfo, pass TermIndex is enough and not that expensive than TransactionInfo. Or keeping the current solution is also an option to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
