adoroszlai commented on code in PR #5874:
URL: https://github.com/apache/ozone/pull/5874#discussion_r1437691939
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsDatanodeService.java:
##########
@@ -149,7 +150,7 @@ public void testDeletedContainersClearedOnShutdown(String
schemaVersion)
StorageVolume volume = volumeSet.getVolumesList().get(0);
// Check instanceof and typecast
- assertTrue(volume instanceof HddsVolume);
+ assertInstanceOf(HddsVolume.class, volume);
HddsVolume hddsVolume = (HddsVolume) volume;
Review Comment:
Just a note for future patches, no need to update this patch for this now.
`assertInstanceOf` returns the object after cast, so this can be simplified
to:
```
HddsVolume hddsVolume = assertInstanceOf(HddsVolume.class, volume);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
