adoroszlai commented on code in PR #5879:
URL: https://github.com/apache/ozone/pull/5879#discussion_r1439016255
##########
hadoop-hdds/rocks-native/pom.xml:
##########
Review Comment:
Thanks @smengcl for the review. With `--ignore-space-change` the diff is
much smaller there:
```diff
diff --git hadoop-hdds/rocks-native/pom.xml hadoop-hdds/rocks-native/pom.xml
index c9480ccbb2..d3a015a18f 100644
--- hadoop-hdds/rocks-native/pom.xml
+++ hadoop-hdds/rocks-native/pom.xml
@@ -25,10 +25,6 @@
<artifactId>hdds-rocks-native</artifactId>
<dependencies>
- <dependency>
- <groupId>org.apache.ozone</groupId>
- <artifactId>hdds-test-utils</artifactId>
- </dependency>
<dependency>
<groupId>org.apache.ozone</groupId>
<artifactId>hdds-managed-rocksdb</artifactId>
@@ -37,19 +33,16 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-io</artifactId>
</dependency>
+
+ <!-- Test dependencies -->
<dependency>
- <groupId>org.junit.jupiter</groupId>
- <artifactId>junit-jupiter-api</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.junit.jupiter</groupId>
- <artifactId>junit-jupiter-params</artifactId>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-hadoop-dependency-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.mockito</groupId>
- <artifactId>mockito-junit-jupiter</artifactId>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-test-utils</artifactId>
<scope>test</scope>
</dependency>
<dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
