sodonnel commented on code in PR #5485:
URL: https://github.com/apache/ozone/pull/5485#discussion_r1439588004
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java:
##########
@@ -263,10 +265,25 @@ private ScanResult scanData(DataTransferThrottler
throttler,
if (getBlockDataFromDBWithLock(db, block) != null) {
// Block was not deleted, the failure is legitimate.
return result;
- } else if (LOG.isDebugEnabled()) {
+ } else {
+ // If schema V3 and container details not in DB or
+ // if containerDBPath is removed
+ if ((onDiskContainerData.hasSchema(OzoneConsts.SCHEMA_V3) &&
Review Comment:
OK - Thanks for looking into it. If checking the map is too difficult, I
think the current way is fine.
There is one conflict that has appeared as this review has been waiting for
a while over the holidays. Could you merge in master and fix the conflict and
then we can proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
