sumitagrawl commented on code in PR #5793: URL: https://github.com/apache/ozone/pull/5793#discussion_r1440025506
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconContainerReportQueue.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.recon.scm; + +import org.apache.hadoop.hdds.scm.server.ContainerReportQueue; +import org.apache.hadoop.hdds.scm.server.SCMDatanodeHeartbeatDispatcher; +import org.apache.hadoop.hdds.scm.server.SCMDatanodeHeartbeatDispatcher.ContainerReport; + +import java.util.List; + +/** + * Customized queue to handle FCR and ICR from datanode optimally, + * avoiding duplicate FCR reports. Review Comment: Customize queue to handle multiple ICR report together ########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconStorageContainerManagerFacade.java: ########## @@ -182,6 +190,21 @@ public ReconStorageContainerManagerFacade(OzoneConfiguration conf, .setSCM(this) .build(); this.ozoneConfiguration = getReconScmConfiguration(conf); + long scmClientRPCTimeOut = ozoneConfiguration.getTimeDuration( + OZONE_RECON_SCM_CLIENT_RPC_TIME_OUT_KEY, + OZONE_RECON_SCM_CLIENT_RPC_TIME_OUT_DEFAULT, + TimeUnit.MILLISECONDS); + long scmClientMaxRetryTimeOut = ozoneConfiguration.getTimeDuration( + OZONE_RECON_SCM_CLIENT_MAX_RETRY_TIMEOUT_KEY, + OZONE_RECON_SCM_CLIENT_MAX_RETRY_TIMEOUT_DEFAULT, + TimeUnit.MILLISECONDS); + int scmClientFailOverMaxRetryCount = ozoneConfiguration.getInt( + OZONE_RECON_SCM_CLIENT_FAILOVER_MAX_RETRY_KEY, + OZONE_RECON_SCM_CLIENT_FAILOVER_MAX_RETRY_DEFAULT); + SCMClientConfig scmClientConfig = conf.getObject(SCMClientConfig.class); Review Comment: do this update for scmClientConfig is getting reflected? as getObject will return new instance. May need update hdds property value directly using recon property to overwrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
