xBis7 commented on PR #5479: URL: https://github.com/apache/ozone/pull/5479#issuecomment-1875211476
@YuanbenWang Can you add a simple unit test for `ProtocolMessageMetrics.java`? You can initialize everything and get the metrics like [TestSCMHAMetrics](https://github.com/apache/ozone/blob/master/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestSCMHAMetrics.java), mock and stub everything else and check that values increment. I think it's odd there are no tests for protocol message metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
