smengcl commented on code in PR #5694:
URL: https://github.com/apache/ozone/pull/5694#discussion_r1440572982
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyRenameRequestWithFSO.java:
##########
@@ -103,8 +103,8 @@ public void testValidateAndUpdateCacheWithToKeyInvalid()
throws Exception {
@Test
public void testValidateAndUpdateCacheWithEmptyToKey() throws Exception {
String emptyToKeyName = "";
- OMRequest omRequest = doPreExecute(createRenameKeyRequest(volumeName,
- bucketName, fromKeyName, emptyToKeyName));
+ OMRequest omRequest = createRenameKeyRequest(volumeName,
+ bucketName, fromKeyName, emptyToKeyName);
Review Comment:
hmm. if we don't call `doPreExecute()` here, then it won't actually execute
the logic in `validateAndUpdateCache` right? doesn't match the test name if
that is the case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
