kerneltime commented on code in PR #5627:
URL: https://github.com/apache/ozone/pull/5627#discussion_r1443412826
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/S3GatewayConfigKeys.java:
##########
@@ -81,6 +81,9 @@ public final class S3GatewayConfigKeys {
public static final boolean OZONE_S3G_LIST_KEYS_SHALLOW_ENABLED_DEFAULT =
true;
+ public static final String
OZONE_S3G_METRICS_PERCENTILES_INTERVALS_SECONDS_KEY
+ = "ozone.s3g.metrics.percentiles.intervals.seconds";
Review Comment:
I am not sure how adding it to `addPropertiesNotInXml` in integration tests
will help customers trying to deploy and use this metric? It makes sense to
have some defaults specified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
