smengcl commented on PR #5920: URL: https://github.com/apache/ozone/pull/5920#issuecomment-1879463260
> You can check out OmMetadataManagerImpl.getExpiredOpenKeys() > > https://github.com/apache/ozone/blob/f4a3b0e64c0cb3f2debaded68dcc0b7573602837/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java#L1808 > > > to see how we tell a key has hsync or not. You shouldn't need to walk through the keyTable. As I can see it is using the same approach as mine to check whether a key is hsync'ed or not. AFAIK the metadata tag is the only way to do it at the moment. Plus `getExpiredOpenKeys` looks to be iterating over the entire `KeyTable`/`FileTable`. Again, the problem is that `OpenKeyTable` doen't have this metadata tag at all. If we can add that it will be much more efficient (both for `getExpiredOpenKeys` and this PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
