[
https://issues.apache.org/jira/browse/HDDS-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804165#comment-17804165
]
Ivan Andika edited comment on HDDS-8157 at 1/8/24 9:59 AM:
-----------------------------------------------------------
[~ckj] [~adoroszlai] This is indeed caused by HDDS-6964 since the test uses
changes from using PrefixManager methods (prefixManagerImpl#addAcl,
prefixManagerImpl#removeAcl, and prefixManagerImpl#setAcl) which contains
validateOzoneObj to OzoneManagerProtocol (OM HA request flow) which does not
have validateOzoneObj.
This will be fixed in HDDS-10066 by adding validateOzoneObj to
OMPrefixAclRequest#validateAndUpdateCache. The OMException assertions will be
re-added back.
was (Author: JIRAUSER298977):
[~ckj] [~adoroszlai] This is indeed caused by HDDS-6964 since validateOzoneObj
methods are removed when prefixManagerImpl#addAcl, prefixManagerImpl#removeAcl,
and prefixManagerImpl#setAcl were removed. validateOzoneObj are supposed to be
added to OMPrefixAclRequest#validateAndUpdateCache.
This will be fixed in HDDS-10066. The OMException assertions will be re-added
back.
> Expected OMException is not thrown in TestKeyManagerImpl#testInvalidPrefixAcl
> -----------------------------------------------------------------------------
>
> Key: HDDS-8157
> URL: https://issues.apache.org/jira/browse/HDDS-8157
> Project: Apache Ozone
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Kaijie Chen
> Assignee: Prashant Pogde
> Priority: Major
>
> See the difference between HDDS-7921 and HDDS-8156
> [https://github.com/apache/ozone/pull/4396/files#r1135258057]
> [https://github.com/apache/ozone/pull/4257/files#r1099826874]
>
> I think it's caused by
> https://github.com/apache/ozone/pull/3653/files#diff-4275d85bf442cb352596248ced7651fcd5e3b09876bb6d2d80464cdf628a23fdR642
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
