[
https://issues.apache.org/jira/browse/HDDS-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804248#comment-17804248
]
Attila Doroszlai commented on HDDS-10087:
-----------------------------------------
[~jianghuazhu], there are some other possible code cleanup items in
{{NodeDecommissionManager}}:
* remove useless {{this.metrics = null}} assignment
* make member variables final
* merge identical {{catch}} blocks in {{mapHostnamesToDatanodes}}
* remove javadoc tag without description: {{\@throws NodeNotFoundException}}
* remove {{throws InvalidHostStringException}} from {{recommissionNodes}} and
{{startMaintenanceNodes}}, as it is never thrown by these methods
Please consider addressing these in the same patch.
> Remove some unused code in NodeDecommissionManager
> --------------------------------------------------
>
> Key: HDDS-10087
> URL: https://issues.apache.org/jira/browse/HDDS-10087
> Project: Apache Ozone
> Issue Type: Improvement
> Components: SCM
> Affects Versions: 1.3.0
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Attachments: image-2024-01-08-19-24-25-160.png
>
>
> There is some unused code in NodeDecommissionManager.
> it's here:
> !image-2024-01-08-19-24-25-160.png!
> We should probably delete them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
