duongkame commented on PR #5966: URL: https://github.com/apache/ozone/pull/5966#issuecomment-1883709703
> Thanks @duongkame for the spotting this. The fix itself looks good. I have two notes: > > 1. `TestHddsConfServlet` is being changed in [HDDS-9847. Replace usage of org.apache.hadoop.http.HttpServer2 #5959](https://github.com/apache/ozone/pull/5959), too, so there will be conflict: > > ```diff > -import org.apache.hadoop.http.HttpServer2; > +import org.apache.hadoop.hdds.server.http.HttpServer2; > ``` > > 2. Let's avoid future cases by banning import of `org.apache.hadoop.thirdparty.com.google.common.**` here: > > https://github.com/apache/ozone/blob/d7e15f5733b997bca60d1921192d7497c6500a37/pom.xml#L1808-L1814 Thanks for the review @adoroszlai. Rebased and made the config to prevent future usage (it's a good one, thanks). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
