[
https://issues.apache.org/jira/browse/HDDS-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797864#comment-17797864
]
Tsz-wo Sze edited comment on HDDS-9536 at 1/10/24 1:41 AM:
-----------------------------------------------------------
HDDS-7117 already has changed using MappedByteBuffer instead of allocating
buffers when the size is larger than ozone.chunk.read.mapped.buffer.threshold
(default 32KB). So, it seems that we don't have do anything here.
[~duongnguyen], Could you run the tests again with the current code?
was (Author: szetszwo):
HDDS-7117 already has changed using MappedByteBuffer instead of allocating
buffers when the size is small than ozone.chunk.read.mapped.buffer.threshold
(default 32KB). So, it seems that we don't have do anything here.
[~duongnguyen], Could you run the tests again with the current code?
> Datanode perf: Copying (heap) buffers is costly
> -----------------------------------------------
>
> Key: HDDS-9536
> URL: https://issues.apache.org/jira/browse/HDDS-9536
> Project: Apache Ozone
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Duong
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
> Attachments: Screenshot 2023-10-25 at 8.44.16 AM.png,
> datanode-on-write2.html, datanode-read-ratis-after-mapped-buffer.html,
> datanode-read-ratis.html
>
>
> Today, datanodes don't use direct buffers for WriteChunk data. When the
> chunks are written to disk, NIO converts those buffers to direct ones and the
> conversion seems to be very costly (please see attached
> [^datanode-on-write2.html]).
> Chunk data proto should be serialized from network/ratis using (pooled)
> direct buffers. That would avoid lots of extra costs not only from buffer
> copying but also from GCing the immediate buffers.
> !Screenshot 2023-10-25 at 8.44.16 AM.png|width=853,height=467!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
