adoroszlai commented on PR #5954:
URL: https://github.com/apache/ozone/pull/5954#issuecomment-1884364021
@jianghuazhu Let me explain the compatibility issue both @szetszwo and
@duongkame mentioned in more detail.
Let's say I already configured `ozone.scm.handler.count.key` in my cluster
to 1000. My cluster will revert back to 100 handlers after I upgrade Ozone to
a version that has this change, since it ignores my setting for the old config
property. That will cause hard to debug performance issues until I find out
the new properties replaced the old one.
We can avoid that by using the hard-coded default value
(`OZONE_SCM_HANDLER_COUNT_DEFAULT`) **only if** `ozone.scm.handler.count.key`
is not set in the config. Of course if the new property is set, that should
take precedence.
So getting the handler count should be something like:
```java
conf.getInt(OZONE_SCM_BLOCK_HANDLER_COUNT_KEY,
conf.getInt(OZONE_SCM_HANDLER_COUNT_KEY,
OZONE_SCM_HANDLER_COUNT_DEFAULT));
```
The same applies to the two other new config keys, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
