adoroszlai commented on PR #5953: URL: https://github.com/apache/ozone/pull/5953#issuecomment-1885380933
Thanks @jianghuazhu for the patch, @sodonnel for the review. > I've a feeling this class got modified recently which may have caused some of these problems Right. > * remove useless `this.metrics = null` assignment This one was added in HDDS-2642. > * merge identical `catch` blocks in `mapHostnamesToDatanodes` > * remove `throws InvalidHostStringException` from `recommissionNodes` and `startMaintenanceNodes`, as it is never thrown by these methods These were introduced in HDDS-9511. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
