adoroszlai commented on code in PR #5957:
URL: https://github.com/apache/ozone/pull/5957#discussion_r1448644169
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -158,12 +155,12 @@ private Comparator<ContainerID>
orderContainersByUsedBytes() {
/**
* Checks whether a Container has the ReplicationType
- * {@link HddsProtos.ReplicationType#EC}.
+ * {@link HddsProtos.ReplicationType#EC} and the Legacy Replication Manger
is enabled.
* @param container container to check
* @return true if the ReplicationType is EC and "hdds.scm.replication
* .enable.legacy" is true, else false
*/
- private boolean isECContainer(ContainerInfo container) {
+ private boolean isECContainerAndLegacyRMEnabled(ContainerInfo container) {
Review Comment:
Maybe it's just me, but this suggests to me as if `Enabled` applies to both
legacy RM and EC container.
How about `isUnsupportedType` (or similar), to hide internal details?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
