smengcl commented on code in PR #5920:
URL: https://github.com/apache/ozone/pull/5920#discussion_r1453925844
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java:
##########
@@ -549,6 +555,134 @@ public void testOzoneAdminCmdList() throws
UnsupportedEncodingException {
execute(ozoneAdminShell, args);
}
+ @Test
+ public void testOzoneAdminCmdListOpenFiles()
+ throws IOException, InterruptedException {
+
+ OzoneConfiguration conf = cluster.getConf();
+ final String hostPrefix = OZONE_OFS_URI_SCHEME + "://" + omServiceId;
+
+ OzoneConfiguration clientConf = getClientConfForOFS(hostPrefix, conf);
+ clientConf.setBoolean(OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, true);
+ FileSystem fs = FileSystem.get(clientConf);
+
+ assertNotEquals(fs.getConf().get(OZONE_FS_HSYNC_ENABLED),
+ "false", OZONE_FS_HSYNC_ENABLED + " is set to false " +
+ "by external force. Must be true to allow hsync to function");
+
+ final String volumeName = "volume-lof";
+ final String bucketName = "buck1";
+
+ String dir1 = hostPrefix + OM_KEY_PREFIX + volumeName + OM_KEY_PREFIX +
+ bucketName + OM_KEY_PREFIX + "dir1";
+ // Create volume, bucket, dir
+ assertTrue(fs.mkdirs(new Path(dir1)));
+ String keyPrefix = OM_KEY_PREFIX + "key";
+
+ final int numKeys = 5;
+ String[] keys = new String[numKeys];
+
+ for (int i = 0; i < numKeys; i++) {
+ keys[i] = dir1 + keyPrefix + i;
+ }
+
+ int pageSize = 3;
+
+ FSDataOutputStream[] streams = new FSDataOutputStream[numKeys];
+ // Create multiple keys and hold them open
+ for (int i = 0; i < numKeys; i++) {
+ streams[i] = fs.create(new Path(keys[i]));
+ streams[i].write(1);
+ }
+
+ String path = "/" + volumeName + "/" + bucketName;
+ try {
+ // Wait for DB flush
+ cluster.getOzoneManager().awaitDoubleBufferFlush();
+
+ String[] args = new String[] {"om", "lof",
+ "-id", omServiceId,
+ "-l", String.valueOf(numKeys + 1), // pagination
+ "-p", path};
+ // Run listopenfiles
+ execute(ozoneAdminShell, args);
+ String cmdRes = getStdOut();
+ // Should have retrieved all 5 open keys
+ for (int i = 0; i < numKeys; i++) {
+ assertTrue(cmdRes.contains(keyPrefix + i));
+ }
+
+ // Try pagination
+ args = new String[] {"om", "lof",
+ "-id", omServiceId,
+ "-l", String.valueOf(pageSize), // pagination
+ "-p", path};
+ execute(ozoneAdminShell, args);
+ cmdRes = getStdOut();
+
+ // Should have retrieved the 1st page only (3 keys)
+ for (int i = 0; i < pageSize; i++) {
+ assertTrue(cmdRes.contains(keyPrefix + i));
+ }
+ for (int i = pageSize; i < numKeys; i++) {
+ assertFalse(cmdRes.contains(keyPrefix + i));
+ }
+ // No hsync'ed file/key at this point
+ assertFalse(cmdRes.contains("\tYes\t"));
+
+ // Get last line of the output which has the continuation token
+ String[] lines = cmdRes.split("\n");
+ String nextCmd = lines[lines.length - 1].trim();
+ String kw = "--start=";
+ String contToken =
+ nextCmd.substring(nextCmd.lastIndexOf(kw) + kw.length());
+
+ args = new String[] {"om", "lof",
+ "-id", omServiceId,
+ "-l", String.valueOf(pageSize), // pagination
+ "-p", path,
+ "-s", contToken};
+ execute(ozoneAdminShell, args);
+ cmdRes = getStdOut();
+
+ // Should have retrieved the 2nd page only (2 keys)
+ for (int i = 0; i < pageSize - 1; i++) {
+ assertFalse(cmdRes.contains(keyPrefix + i));
+ }
+ // Note: key2 is shown in the continuation token prompt
+ for (int i = pageSize - 1; i < numKeys; i++) {
+ assertTrue(cmdRes.contains(keyPrefix + i));
+ }
+
+ // hsync last key
+ streams[numKeys - 1].hsync();
+ // Wait for flush
+ cluster.getOzoneManager().awaitDoubleBufferFlush();
+
+ execute(ozoneAdminShell, args);
+ cmdRes = getStdOut();
+
+ // Verify that only one key is hsync'ed
+ assertTrue(cmdRes.contains("\tYes\t"), "One key should be hsync'ed");
+ assertTrue(cmdRes.contains("\tNo\t"), "One key should not be hsync'ed");
+ } finally {
+ // Cleanup
+ for (int i = 0; i < numKeys; i++) {
+ streams[i].close();
+ }
Review Comment:
nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
