jianghuazhu commented on code in PR #6012:
URL: https://github.com/apache/ozone/pull/6012#discussion_r1454406648
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -173,6 +174,16 @@ protected KeyArgs resolveBucketAndCheckOpenKeyAcls(KeyArgs
keyArgs,
return resolvedArgs;
}
+ protected void validateKeyName(OzoneManager ozoneManager, String keyName)
Review Comment:
Thanks @hemantk-12 .
The verification key name is different in OMFileCreateRequest,
OMKeyCommitRequest, OMKeyCreateRequest, and OMKeyRenameRequest.
`
OMFileCreateRequest, Verify
keyName=StringUtils.removeEnd(keyArgs.getKeyName(),
OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX)
`
`
OMKeyCommitRequest, Verify
keyName=StringUtils.removeEnd(keyArgs.getKeyName(),OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX)
`
`
OMKeyCreateRequest, Verify keyName=keyArgs.getKeyName()
`
`
OMKeyRenameRequest, Verify keyName=keyRequest.getToKeyName()
`
So I extracted the keyName separately as a parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
