sodonnel commented on code in PR #5856:
URL: https://github.com/apache/ozone/pull/5856#discussion_r1455193349
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -612,6 +613,29 @@ public List<HddsProtos.Node> queryNode(
return result;
}
+ @Override
+ public HddsProtos.Node queryNode(UUID uuid)
+ throws IOException {
+ HddsProtos.Node result = null;
+ for (DatanodeDetails node : scm.getScmNodeManager().getAllNodes()) {
+ try {
+ if (node.getUuid().equals(uuid)) {
+ NodeStatus ns = scm.getScmNodeManager().getNodeStatus(node);
Review Comment:
Node manager has an API to get a node by UUID directly:
```
public DatanodeDetails getNodeByUuid(UUID uuid);
public DatanodeDetails getNodeByUuid(String uuid);
```
So it would be better to use that than iterate all nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
