sodonnel commented on code in PR #5929:
URL: https://github.com/apache/ozone/pull/5929#discussion_r1455761510
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -587,6 +588,16 @@ public void deleteContainer(long containerID) throws
IOException {
}
}
+ @Override
+ public Map<String, List<ContainerID>>
getContainersOnDecomNode(DatanodeDetails dn) throws IOException {
+ try {
+ return
scm.getScmDecommissionManager().getMonitor().getContainersReplicatedOnNode(
Review Comment:
I think it would be cleaner if we did not expose the monitor outside of
ScmDecommissionManager. Instead, create a method on ScmDecommissionManager like
`getContainersReplicatedOnNode(DatanodeDetails dn)` and have it return the
details it gets from the monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
