adoroszlai commented on code in PR #6009:
URL: https://github.com/apache/ozone/pull/6009#discussion_r1455901896


##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestTarContainerPacker.java:
##########
@@ -382,7 +382,7 @@ private File writeDbFile(
 
   private File writeSingleFile(Path parentPath, String fileName,
       String content) throws IOException {
-    Path path = parentPath.resolve(fileName);
+    Path path = parentPath.resolve(fileName).normalize();

Review Comment:
   `File.exists()` seems to have changed:
   
   Test:
   
   ```
   Path p = Paths.get("a/b/c/../f");
   Path parent = p.getParent();
   Files.createDirectories(parent);
   assertThat(parent.normalize()).exists();
   assertThat(parent).exists();
   ```
   
   Java 11 fails at the second assertion:
   
   ```
   AssertionError: 
   
   Expecting path:
     <a/b/c/..>
   to exist
   ```
   
   Java 8 passes the same test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to