hemantk-12 commented on code in PR #6026:
URL: https://github.com/apache/ozone/pull/6026#discussion_r1457735287
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java:
##########
@@ -252,13 +252,10 @@ public DBCheckpoint getCheckpoint(Path tmpdir, boolean
flush)
checkpoint = getDbStore().getCheckpoint(flush);
} finally {
// Unpause the compaction threads.
- synchronized (getDbStore().getRocksDBCheckpointDiffer()) {
- differ.decrementTarballRequestCount();
- differ.notifyAll();
- long elapsedTime = System.currentTimeMillis() - startTime;
- LOG.info("Compaction pausing {} ended. Elapsed ms: {}",
- pauseCounter, elapsedTime);
- }
+ differ.decrementTarballRequestCount();
+ differ.notifyAll();
Review Comment:
To fix the deadlock, I moved `notifyAll()` inside a synchronized block and
removed the nested locks in `RocksDBCheckpointDiffer#pruneSstFiles`.
RocksDBCheckpointDiffer's instance lock is only needed to know which sstFiles
can be removed. Once that's know, actual removal has to be inside
`BootstrapStateHandler#lock`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
