hemantk-12 commented on code in PR #6006:
URL: https://github.com/apache/ozone/pull/6006#discussion_r1457924359
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/ClientProtocolStub.java:
##########
@@ -642,6 +642,13 @@ public String createSnapshot(String volumeName,
return "";
}
+ @Override
+ public void renameSnapshot(String volumeName, String bucketName,
+ String fromSnapshotName, String toSnapshotName)
Review Comment:
nit: to align with other places.
```suggestion
String snapshotOldName, String snapshotNewName)
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotRenameRequest.java:
##########
@@ -0,0 +1,243 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.snapshot;
+
+import static
org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.FILE_ALREADY_EXISTS;
+import static
org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.FILE_NOT_FOUND;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.SNAPSHOT_LOCK;
+import static
org.apache.hadoop.ozone.om.upgrade.OMLayoutFeature.FILESYSTEM_SNAPSHOT;
+
+import java.io.IOException;
+import java.nio.file.InvalidPathException;
+import org.apache.hadoop.hdds.utils.db.cache.CacheKey;
+import org.apache.hadoop.hdds.utils.db.cache.CacheValue;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.audit.AuditLogger;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OmMetadataManagerImpl;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.SnapshotChainManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
+import org.apache.hadoop.ozone.om.request.OMClientRequest;
+import org.apache.hadoop.ozone.om.request.util.OmResponseUtil;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.snapshot.OMSnapshotRenameResponse;
+import org.apache.hadoop.ozone.om.snapshot.RequireSnapshotFeatureState;
+import org.apache.hadoop.ozone.om.upgrade.DisallowedUntilLayoutVersion;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMRequest;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMResponse;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.RenameSnapshotRequest;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.UserInfo;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.util.Time;
+import org.apache.ratis.server.protocol.TermIndex;
+
+/**
+ * Changes snapshot name.
+ */
+public class OMSnapshotRenameRequest extends OMClientRequest {
+
+ public OMSnapshotRenameRequest(OMRequest omRequest) {
+ super(omRequest);
+ }
+
+ @Override
+ @DisallowedUntilLayoutVersion(FILESYSTEM_SNAPSHOT)
+ @RequireSnapshotFeatureState(true)
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+ final OMRequest omRequest = super.preExecute(ozoneManager);
+
+ final RenameSnapshotRequest renameSnapshotRequest =
+ omRequest.getRenameSnapshotRequest();
+
+ final String snapshotNewName = renameSnapshotRequest.getSnapshotNewName();
+
+ OmUtils.validateSnapshotName(snapshotNewName);
+
+ String volumeName = renameSnapshotRequest.getVolumeName();
+ String bucketName = renameSnapshotRequest.getBucketName();
+
+ // Permission check
+ UserGroupInformation ugi = createUGIForApi();
+ String bucketOwner = ozoneManager.getBucketOwner(volumeName, bucketName,
+
IAccessAuthorizer.ACLType.READ, OzoneObj.ResourceType.BUCKET);
+ if (!ozoneManager.isAdmin(ugi) &&
+ !ozoneManager.isOwner(ugi, bucketOwner)) {
+ throw new OMException(
+ "Only bucket owners and Ozone admins can rename snapshots",
+ OMException.ResultCodes.PERMISSION_DENIED);
+ }
+
+ // Set rename time here so OM leader and follower would have the
+ // exact same timestamp.
+ OMRequest.Builder omRequestBuilder = omRequest.toBuilder()
+ .setRenameSnapshotRequest(
+ RenameSnapshotRequest.newBuilder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setSnapshotNewName(snapshotNewName)
+ .setSnapshotOldName(renameSnapshotRequest.getSnapshotOldName())
+ .setRenameTime(Time.now()));
+
+ return omRequestBuilder.build();
+ }
+
+
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ TermIndex termIndex) {
+ boolean acquiredBucketLock = false;
+ boolean acquiredSnapshotOldLock = false;
+ boolean acquiredSnapshotNewLock = false;
+ Exception exception = null;
+ OmMetadataManagerImpl omMetadataManager = (OmMetadataManagerImpl)
+ ozoneManager.getMetadataManager();
+
+ OMResponse.Builder omResponse = OmResponseUtil.getOMResponseBuilder(
+ getOmRequest());
+ OMClientResponse omClientResponse = null;
+ AuditLogger auditLogger = ozoneManager.getAuditLogger();
+
+ UserInfo userInfo = getOmRequest().getUserInfo();
+
+ final RenameSnapshotRequest request =
+ getOmRequest().getRenameSnapshotRequest();
+
+ final String volumeName = request.getVolumeName();
+ final String bucketName = request.getBucketName();
+ final String snapshotNewName = request.getSnapshotNewName();
+ final String snapshotOldName = request.getSnapshotOldName();
+
+ SnapshotInfo snapshotOldInfo = null;
+
+ try {
+ // Acquire bucket lock
+ mergeOmLockDetails(
+ omMetadataManager.getLock().acquireWriteLock(BUCKET_LOCK,
+ volumeName,
bucketName));
+ acquiredBucketLock = getOmLockDetails().isLockAcquired();
+
+
mergeOmLockDetails(omMetadataManager.getLock().acquireWriteLock(SNAPSHOT_LOCK,
+ volumeName, bucketName,
snapshotOldName));
+ acquiredSnapshotOldLock = getOmLockDetails().isLockAcquired();
+
+
mergeOmLockDetails(omMetadataManager.getLock().acquireWriteLock(SNAPSHOT_LOCK,
+ volumeName, bucketName,
snapshotNewName));
+ acquiredSnapshotNewLock = getOmLockDetails().isLockAcquired();
+
+ // Retrieve SnapshotInfo from the table
+ String snapshotNewTableKey = SnapshotInfo.getTableKey(volumeName,
bucketName, snapshotNewName);
+
+ if
(omMetadataManager.getSnapshotInfoTable().isExist(snapshotNewTableKey)) {
+ throw new OMException("Snapshot with name " + snapshotNewName +
"already exist",
+ FILE_ALREADY_EXISTS);
+ }
+
+ // Retrieve SnapshotInfo from the table
+ String snapshotOldTableKey = SnapshotInfo.getTableKey(volumeName,
bucketName,
+ snapshotOldName);
+ snapshotOldInfo =
+ omMetadataManager.getSnapshotInfoTable().get(snapshotOldTableKey);
+
+ if (snapshotOldInfo == null) {
+ // Snapshot does not exist
+ throw new OMException("Snapshot with name " + snapshotOldName + "does
not exist",
+ FILE_NOT_FOUND);
+ }
+
+ switch (snapshotOldInfo.getSnapshotStatus()) {
+ case SNAPSHOT_DELETED:
+ throw new OMException("Snapshot is already deleted. "
+ + "Pending reclamation.", FILE_NOT_FOUND);
+ case SNAPSHOT_ACTIVE:
+ break;
+ default:
+ // Unknown snapshot non-active state
+ throw new OMException("Snapshot exists but no longer in active state",
+ FILE_NOT_FOUND);
+ }
+
+ snapshotOldInfo.setName(snapshotNewName);
+
+ omMetadataManager.getSnapshotInfoTable().addCacheEntry(
+ new CacheKey<>(snapshotOldTableKey),
+ CacheValue.get(termIndex.getIndex()));
+
+ omMetadataManager.getSnapshotInfoTable().addCacheEntry(
+ new CacheKey<>(snapshotNewTableKey),
+ CacheValue.get(termIndex.getIndex(), snapshotOldInfo));
+
+ updateSnapshotInChainManager(omMetadataManager, snapshotOldInfo);
+
+
ozoneManager.getOmSnapshotManager().getSnapshotCache().invalidate(snapshotOldTableKey);
Review Comment:
1. I don't think it is good idea to invalidate the cache because of snapshot
rename. I guess better approach would be to use snapshotId as key for
snapshotCache.
2. Unit test is failing due to NPE in this line. Please take a look of that.
```
Error: Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
4.973 s <<< FAILURE! -- in
org.apache.hadoop.ozone.om.request.snapshot.TestOMSnapshotRenameRequest
Error:
org.apache.hadoop.ozone.om.request.snapshot.TestOMSnapshotRenameRequest.testValidateAndUpdateCache
-- Time elapsed: 0.178 s <<< ERROR!
java.lang.NullPointerException
at
org.apache.hadoop.ozone.om.request.snapshot.OMSnapshotRenameRequest.validateAndUpdateCache(OMSnapshotRenameRequest.java:192)
at
org.apache.hadoop.ozone.om.request.OMClientRequest.validateAndUpdateCache(OMClientRequest.java:145)
at
org.apache.hadoop.ozone.om.request.snapshot.TestOMSnapshotRenameRequest.testValidateAndUpdateCache(TestOMSnapshotRenameRequest.java:217)
at java.lang.reflect.Method.invoke(Method.java:498)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at java.util.ArrayList.forEach(ArrayList.java:1259
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotRenameRequest.java:
##########
@@ -0,0 +1,243 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.snapshot;
+
+import static
org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.FILE_ALREADY_EXISTS;
+import static
org.apache.hadoop.ozone.om.exceptions.OMException.ResultCodes.FILE_NOT_FOUND;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.SNAPSHOT_LOCK;
+import static
org.apache.hadoop.ozone.om.upgrade.OMLayoutFeature.FILESYSTEM_SNAPSHOT;
+
+import java.io.IOException;
+import java.nio.file.InvalidPathException;
+import org.apache.hadoop.hdds.utils.db.cache.CacheKey;
+import org.apache.hadoop.hdds.utils.db.cache.CacheValue;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.audit.AuditLogger;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OmMetadataManagerImpl;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.SnapshotChainManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
+import org.apache.hadoop.ozone.om.request.OMClientRequest;
+import org.apache.hadoop.ozone.om.request.util.OmResponseUtil;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.snapshot.OMSnapshotRenameResponse;
+import org.apache.hadoop.ozone.om.snapshot.RequireSnapshotFeatureState;
+import org.apache.hadoop.ozone.om.upgrade.DisallowedUntilLayoutVersion;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMRequest;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMResponse;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.RenameSnapshotRequest;
+import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.UserInfo;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.util.Time;
+import org.apache.ratis.server.protocol.TermIndex;
+
+/**
+ * Changes snapshot name.
+ */
+public class OMSnapshotRenameRequest extends OMClientRequest {
+
+ public OMSnapshotRenameRequest(OMRequest omRequest) {
+ super(omRequest);
+ }
+
+ @Override
+ @DisallowedUntilLayoutVersion(FILESYSTEM_SNAPSHOT)
+ @RequireSnapshotFeatureState(true)
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+ final OMRequest omRequest = super.preExecute(ozoneManager);
+
+ final RenameSnapshotRequest renameSnapshotRequest =
+ omRequest.getRenameSnapshotRequest();
+
+ final String snapshotNewName = renameSnapshotRequest.getSnapshotNewName();
+
+ OmUtils.validateSnapshotName(snapshotNewName);
+
+ String volumeName = renameSnapshotRequest.getVolumeName();
+ String bucketName = renameSnapshotRequest.getBucketName();
+
+ // Permission check
+ UserGroupInformation ugi = createUGIForApi();
+ String bucketOwner = ozoneManager.getBucketOwner(volumeName, bucketName,
+
IAccessAuthorizer.ACLType.READ, OzoneObj.ResourceType.BUCKET);
+ if (!ozoneManager.isAdmin(ugi) &&
+ !ozoneManager.isOwner(ugi, bucketOwner)) {
+ throw new OMException(
+ "Only bucket owners and Ozone admins can rename snapshots",
+ OMException.ResultCodes.PERMISSION_DENIED);
+ }
+
+ // Set rename time here so OM leader and follower would have the
+ // exact same timestamp.
+ OMRequest.Builder omRequestBuilder = omRequest.toBuilder()
+ .setRenameSnapshotRequest(
+ RenameSnapshotRequest.newBuilder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setSnapshotNewName(snapshotNewName)
+ .setSnapshotOldName(renameSnapshotRequest.getSnapshotOldName())
+ .setRenameTime(Time.now()));
+
+ return omRequestBuilder.build();
+ }
+
+
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ TermIndex termIndex) {
+ boolean acquiredBucketLock = false;
+ boolean acquiredSnapshotOldLock = false;
+ boolean acquiredSnapshotNewLock = false;
+ Exception exception = null;
+ OmMetadataManagerImpl omMetadataManager = (OmMetadataManagerImpl)
+ ozoneManager.getMetadataManager();
+
+ OMResponse.Builder omResponse = OmResponseUtil.getOMResponseBuilder(
+ getOmRequest());
+ OMClientResponse omClientResponse = null;
+ AuditLogger auditLogger = ozoneManager.getAuditLogger();
+
+ UserInfo userInfo = getOmRequest().getUserInfo();
+
+ final RenameSnapshotRequest request =
+ getOmRequest().getRenameSnapshotRequest();
+
+ final String volumeName = request.getVolumeName();
+ final String bucketName = request.getBucketName();
+ final String snapshotNewName = request.getSnapshotNewName();
+ final String snapshotOldName = request.getSnapshotOldName();
+
+ SnapshotInfo snapshotOldInfo = null;
+
+ try {
+ // Acquire bucket lock
+ mergeOmLockDetails(
+ omMetadataManager.getLock().acquireWriteLock(BUCKET_LOCK,
+ volumeName,
bucketName));
+ acquiredBucketLock = getOmLockDetails().isLockAcquired();
+
+
mergeOmLockDetails(omMetadataManager.getLock().acquireWriteLock(SNAPSHOT_LOCK,
+ volumeName, bucketName,
snapshotOldName));
+ acquiredSnapshotOldLock = getOmLockDetails().isLockAcquired();
+
+
mergeOmLockDetails(omMetadataManager.getLock().acquireWriteLock(SNAPSHOT_LOCK,
+ volumeName, bucketName,
snapshotNewName));
+ acquiredSnapshotNewLock = getOmLockDetails().isLockAcquired();
+
+ // Retrieve SnapshotInfo from the table
+ String snapshotNewTableKey = SnapshotInfo.getTableKey(volumeName,
bucketName, snapshotNewName);
+
+ if
(omMetadataManager.getSnapshotInfoTable().isExist(snapshotNewTableKey)) {
+ throw new OMException("Snapshot with name " + snapshotNewName +
"already exist",
+ FILE_ALREADY_EXISTS);
+ }
+
+ // Retrieve SnapshotInfo from the table
+ String snapshotOldTableKey = SnapshotInfo.getTableKey(volumeName,
bucketName,
+ snapshotOldName);
+ snapshotOldInfo =
+ omMetadataManager.getSnapshotInfoTable().get(snapshotOldTableKey);
+
+ if (snapshotOldInfo == null) {
+ // Snapshot does not exist
+ throw new OMException("Snapshot with name " + snapshotOldName + "does
not exist",
+ FILE_NOT_FOUND);
+ }
+
+ switch (snapshotOldInfo.getSnapshotStatus()) {
+ case SNAPSHOT_DELETED:
+ throw new OMException("Snapshot is already deleted. "
+ + "Pending reclamation.", FILE_NOT_FOUND);
+ case SNAPSHOT_ACTIVE:
+ break;
+ default:
+ // Unknown snapshot non-active state
+ throw new OMException("Snapshot exists but no longer in active state",
+ FILE_NOT_FOUND);
+ }
+
+ snapshotOldInfo.setName(snapshotNewName);
+
+ omMetadataManager.getSnapshotInfoTable().addCacheEntry(
+ new CacheKey<>(snapshotOldTableKey),
+ CacheValue.get(termIndex.getIndex()));
+
+ omMetadataManager.getSnapshotInfoTable().addCacheEntry(
+ new CacheKey<>(snapshotNewTableKey),
+ CacheValue.get(termIndex.getIndex(), snapshotOldInfo));
+
+ updateSnapshotInChainManager(omMetadataManager, snapshotOldInfo);
+
+
ozoneManager.getOmSnapshotManager().getSnapshotCache().invalidate(snapshotOldTableKey);
+
+ omResponse.setRenameSnapshotResponse(
+ OzoneManagerProtocolProtos.RenameSnapshotResponse.newBuilder()
+ .setSnapshotInfo(snapshotOldInfo.getProtobuf()));
+ omClientResponse = new OMSnapshotRenameResponse(
+ omResponse.build(), snapshotOldTableKey, snapshotNewTableKey,
snapshotOldInfo);
+
+ } catch (IOException | InvalidPathException ex) {
+ exception = ex;
+ omClientResponse = new OMSnapshotRenameResponse(
+ createErrorOMResponse(omResponse, exception));
+ } finally {
+ if (acquiredSnapshotNewLock) {
+
mergeOmLockDetails(omMetadataManager.getLock().releaseWriteLock(SNAPSHOT_LOCK,
volumeName,
+ bucketName,
snapshotNewName));
+ }
+ if (acquiredSnapshotOldLock) {
+
mergeOmLockDetails(omMetadataManager.getLock().releaseWriteLock(SNAPSHOT_LOCK,
volumeName,
+ bucketName,
snapshotOldName));
+ }
+ if (acquiredBucketLock) {
+
mergeOmLockDetails(omMetadataManager.getLock().releaseWriteLock(BUCKET_LOCK,
volumeName,
+ bucketName));
+ }
+ if (omClientResponse != null) {
+ omClientResponse.setOmLockDetails(getOmLockDetails());
+ }
+ }
+
+ if (snapshotOldInfo == null) {
+ // Dummy SnapshotInfo for logging and audit logging when erred
+ snapshotOldInfo = SnapshotInfo.newInstance(volumeName, bucketName,
+ snapshotOldName, null,
Time.now());
+ }
+
+ // Perform audit logging outside the lock
+ auditLog(auditLogger, buildAuditMessage(OMAction.RENAME_SNAPSHOT,
+ snapshotOldInfo.toAuditMap(),
exception, userInfo));
+ return omClientResponse;
+ }
+
+ private void updateSnapshotInChainManager(OmMetadataManagerImpl
omMetadataManager, SnapshotInfo snapshotInfo) {
Review Comment:
nit: This doesn't need to be a separate function. Please directly call
`snapshotChainManager.updateSnapshot(snapshotInfo);` since `updateSnapshot()`
is synchronized operation.
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/RenameSnapshotHandler.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.shell.snapshot;
+
+import java.io.IOException;
+import org.apache.hadoop.ozone.OmUtils;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientException;
+import org.apache.hadoop.ozone.shell.Handler;
+import org.apache.hadoop.ozone.shell.OzoneAddress;
+import org.apache.hadoop.ozone.shell.bucket.BucketUri;
+import picocli.CommandLine;
+
+/**
+ * ozone sh snapshot rename.
+ */
[email protected](name = "rename",
+ description = "Rename a snapshot")
+public class RenameSnapshotHandler extends Handler {
+
+ @CommandLine.Mixin
+ private BucketUri snapshotPath;
+
+ @CommandLine.Parameters(description = "Current snapshot name",
+ index = "1", arity = "1")
+ private String fromSnapshotName;
Review Comment:
Same as previous comment, use `snapshotOldName` and `snapshotNewName` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
