aswinshakil commented on code in PR #6024:
URL: https://github.com/apache/ozone/pull/6024#discussion_r1458108560
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/ReferenceCounted.java:
##########
@@ -52,9 +52,10 @@ public class ReferenceCounted<T, U>
* Parent instance whose callback will be triggered upon this RC closure.
*/
private final U parentWithCallback;
+ private final K parentKey;
Review Comment:
I agree with the 2nd point. There is no need to have a separate `parentKey`
we can just use `((OmSnapshot) referenceCounted.get()).getSnapshotTableKey()`
to get the key. I fell like this is only adding more things to change in the
codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
