Montura commented on PR #5758:
URL: https://github.com/apache/ozone/pull/5758#issuecomment-1899905581

   > @Montura Is it possible to just add the new test using the existing 
testing framework in the current PR, while other improvements/refactoring can 
be done in future jiras?
   
   It can be done in a very ugly way. Because I need to run `N testable 
clusters` with different number of DNs, so each cluster encapsulates 
`ContainerBalancer` and `ContainerBalancerTask` too. For now only the field 
`ContainerBalancerTask` is sharing between the all the tests and cluster with 
hardcoded 10 DNs is initialized by default before each test.
   
   Maybe I can create a new `TestContainerBalancerTask2` (an example name) file 
, move a few code from `TestContainerBalancerTask` and use a new framework? 
   
   In next PR I'll merge these two tests with a new test framework.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to