devmadhuu opened a new pull request, #6034:
URL: https://github.com/apache/ozone/pull/6034

   ## What changes were proposed in this pull request?
   This PR is raised to incorporate below tasks:
   
   `AbstractReconSqlDBTest uses Files.createTempDirectory. We should replace it 
with @TempDir. The problem is that AbstractReconSqlDBTest is used in two 
different ways:`
   
   ```
   Several tests extend AbstractReconSqlDBTest. JUnit lifecycle method is 
executed, @TempDir can be used.
   ReconTestInjector and TestReconWithDifferentSqlDBs create instance of 
AbstractReconSqlDBTest explicitly. These should provide temp directory via 
parameter.
   ```
   
   ## What is the link to the Apache JIRA
   
   Please create an issue in ASF JIRA before opening a pull request, and you 
need to set the title of the pull
   request which starts with the corresponding JIRA issue number. (e.g. 
HDDS-XXXX. Fix a typo in YYY.)
   
   (Please replace this section with the link to the Apache JIRA)
   https://issues.apache.org/jira/browse/HDDS-9968
   
   ## How was this patch tested?
   This patch is being tested by executing all existing test cases which are 
extending and using `AbstractReconSqlDBTest` and  ReconTestInjector classes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to